Use $SETPRIV in mkdir/stat command when necessary #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new copy offload container, the container is ran as the specified user, so setpriv commands are not necessary to preserve the proper permissions. However, for DataIn/DataOut DM, data movement is still performed as root in the nnf-dm containers. Setpriv is necessary in this case. This change determines the UID of the user and appropriate uses/drops the setprivCommand defined by the DM profile when issuing mkdir and stat commands. The same is done for the main DM command to remove --uid/--gid from dcp when running in copy-offload. These changes removes the need to have separate DM profiles for copy offload. Signed-off-by: Blake Devcich <[email protected]>
bdevcich
commented
Mar 3, 2025
go.mod
Outdated
| github.com/NearNodeFlash/nnf-ec v0.0.1-0.20250219193635-3e6c6b39d0e0 // indirect | ||
| github.com/NearNodeFlash/nnf-sos v0.0.1-0.20250221193225-b496a821842d | ||
| github.com/NearNodeFlash/nnf-ec v0.0.1-0.20250220202952-3c878bceb55c // indirect | ||
| github.com/NearNodeFlash/nnf-sos v0.0.1-0.20250226162446-00a9dace0693 |
There was a problem hiding this comment.
Reminder to update nnf-sos after its merge
ajfloeder
approved these changes
Mar 3, 2025
matthew-richerson
approved these changes
Mar 3, 2025
ajfloeder
approved these changes
Mar 4, 2025
roehrich-hpe
approved these changes
Mar 4, 2025
bdevcich
added a commit
that referenced
this pull request
Mar 4, 2025
This is no longer needed after #279. Signed-off-by: Blake Devcich <[email protected]>
bdevcich
added a commit
that referenced
this pull request
Mar 4, 2025
This is no longer needed after #279. Signed-off-by: Blake Devcich <[email protected]>
Signed-off-by: Blake Devcich <[email protected]>
bdevcich
added a commit
that referenced
this pull request
Mar 4, 2025
This is no longer needed after #279. Signed-off-by: Blake Devcich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new copy offload container, the container is ran as the
specified user, so setpriv commands are not necessary to preserve the
proper permissions. However, for DataIn/DataOut DM, data movement is
still performed as root in the nnf-dm containers. Setpriv is necessary
in this case.
This change determines the UID of the user and appropriate uses/drops
the setprivCommand defined by the DM profile when issuing mkdir and stat
commands.
The same is done for the main DM command to remove --uid/--gid from dcp
when running in copy-offload.
These changes removes the need to have separate DM profiles for copy
offload.
Signed-off-by: Blake Devcich [email protected]