Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the nnf-mfu release to be specified. #64

Merged
merged 5 commits into from
May 16, 2023
Merged

Conversation

roehrich-hpe
Copy link
Contributor

No description provided.

@roehrich-hpe
Copy link
Contributor Author

Here's the NNFContainerProfile example resource that is installed as a result of this change:

$ kubectl get nnfcontainerprofiles -n nnf-system example-mpi -o yaml | grep image:
              image: ghcr.io/nearnodeflash/nnf-mfu:0.0.1
            - image: ghcr.io/nearnodeflash/nnf-mfu:0.0.1

@bdevcich
Copy link
Contributor

Do you plan on doing this for nnf-dm as well? It's also used there for data movement. https://github.com/search?q=repo%3ANearNodeFlash%2Fnnf-dm%20mfu&type=code

Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Copy link
Contributor Author

Do you plan on doing this for nnf-dm as well? It's also used there for data movement. https://github.com/search?q=repo%3ANearNodeFlash%2Fnnf-dm%20mfu&type=code

Well. Shoot.

Add an environment variable to indicate which version of nnf-mfu should be
used.

Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Copy link
Contributor Author

Here are the results with the newest nnf-dm, from PR NearNodeFlash/nnf-dm#106

$ kubectl get datamovementmanager -n nnf-dm-system   nnf-dm-manager-controller-manager -o yaml | grep -e image: -e name:
  name: nnf-dm-manager-controller-manager
        image: ghcr.io/nearnodeflash/nnf-mfu:0.0.1
        name: worker
        - name: NNF_NODE_NAME
        image: ghcr.io/nearnodeflash/nnf-dm:d6b3864f6026ba2a219c7d6d481f35df26cca031
        name: manager

$ docker inspect --format='{{json .Config.Labels}}' ghcr.io/nearnodeflash/nnf-dm:d6b3864f6026ba2a219c7d6d481f35df26cca031
{"nnf-mfu":"ghcr.io/nearnodeflash/nnf-mfu:0.0.1"}


$ kubectl get nnfcontainerprofiles -n nnf-system example-mpi -o yaml | grep image:                                       
              image: ghcr.io/nearnodeflash/nnf-mfu:0.0.1
            - image: ghcr.io/nearnodeflash/nnf-mfu:0.0.1

Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe roehrich-hpe merged commit cfd0b67 into master May 16, 2023
@roehrich-hpe roehrich-hpe deleted the specify-nnf-mfu branch May 16, 2023 18:44
@bdevcich bdevcich mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants