Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the release phase verify that any submodules have been released. #179

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

roehrich-hpe
Copy link
Contributor

Detect the case when a release is being created from submodules that are not released.

Detect the case when a release is being created from submodules that are not
released.

Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Copy link
Contributor

@bdevcich bdevcich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me for nnf-docs:

  Submodule status
+e0c318ca1d61325da1d6677a55de432043a8c1e8 external/nnf-dm (v0.0.0-224-ge0c318ca)
  Has the submodule been released yet?

@roehrich-hpe roehrich-hpe merged commit 86eb080 into master Jul 16, 2024
1 check passed
@roehrich-hpe roehrich-hpe deleted the rel-tool-submod branch July 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants