Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.0.7 #112

Merged
merged 26 commits into from
Jan 17, 2024
Merged

Release v0.0.7 #112

merged 26 commits into from
Jan 17, 2024

Conversation

ajfloeder
Copy link
Contributor

No description provided.

bdevcich and others added 25 commits September 25, 2023 11:56
@bdevcich
Update clientmountd service account name/namespace after DWS move
0bc6d13 
Fix some formatting too.
@ajfloeder
add tds configuration information (#89)
7b1f34c 
* add tds configuration information

* Remove old config
@roehrich-hpe
Move to cert-manager 1.13.1 (#90)
c9c6563 
Cert-manager 1.12.0 and 1.13.0 were big releases.  It's time to catch up.

Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Update submodules for ginkgo and controller-runtime (#91)
cd9d287 
Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Move DWS from HewlettPackard/dws to DataWorkflowServices/dws (#92)
c0b389c 
Update the DWS API group in the kube-apiserver audit_policy config.

Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Update the project for kubebuilder go/v4 layout (#93)
3c49e3c 
Change the layout to follow the Standard Go Project Layout, as described
in https://book.kubebuilder.io/migration/v3vsv4.  This allows newer releases
of kubebuilder to be used with this repo

Signed-off-by: Dean Roehrich <[email protected]>
@ajfloeder
Adjust copy action for the texas admin node. Need to use the -O optio…
ae771cb 
…n for scp. Also, comment out chassis1 rabbit for the time being. (#94)
@roehrich-hpe
Set the maxsize for the audit log in a KIND env (#95)
5df80d4 
Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Reduce the size of the audit log summary (#96)
df39ba6 
The .objectRef.name is already printed with the .requestURI.

Signed-off-by: Dean Roehrich <[email protected]>
@roehrich-hpe
Requirements for Prometheus (#97)
8620e4f 
Introduce a deploy-prometheus.sh script that can install the
prometheus-community/kube-prometheus-stack helm chart.  Include a file that
overrides the ServiceMonitor selector in the chart's values.yaml.  This
selector inserts a label that is common across the ServiceMonitor resources
in the DWS and NNF repos.

Signed-off-by: Dean Roehrich <[email protected]>
@bdevcich
Account for nnf-dm no longer having CRDs
f432daf 
As part of the NnfDataMovementManager move to nnf-sos, nnf-do does not
have its own CRDs anymore and therefor does not have a `make install` or
`make uninstall` target.

Update submodules after NnfDataMovementManager move

Signed-off-by: Blake Devcich <[email protected]>
@bdevcich
Add k8sHost + k8sPort to systems config (#99)
3621330 
The texas system's compute nodes cannot hit the k8s cluster with the
public facing IP like our other systems.

This change adds additional configuration for k8s host and port that is
fed into the daemons' configuration so they are able to talk to the
cluster from the computes using a separate host/port, if necessary.

Signed-off-by: Blake Devcich <[email protected]>
@jameshcorbett @bdevcich
Readme: fix build instructions
4071634 
Problem: Readme.md indicates that 'go build' in the root directory
will build nnf-deploy, but this is not the case since 3c49e3c.

Fix the instructions to say that running 'make' is the proper way
to build the nnf-deploy executable.
@bdevcich
Add examples-htx overlay to htx (#101)
de5f990 
In nnf-sos, the default storage and container profiles are deployed
separately from the default configuration via `examples`.

In order to overlay on top of the examples, we must add the ability to
get the examples overlay separately and pass it through to the makefile
via OVERLAY_EXAMPLES env var.

Signed-off-by: Blake Devcich <[email protected]>
@bdevcich
Rename the htx computes in the SystemConfiguration
d38a156 
These should match the hostnames on the computes themselves.

Signed-off-by: Blake Devcich <[email protected]>
@roehrich-hpe
Use a bare SystemConfiguration CR (#103)
d977d17 
We no longer generate the SystemConfiguration resource from
`config/systems.yaml`.  Instead, we store the actual resource as a YAML text
file in the `config/` directory and refer to it from the `config/systems.yaml`
file.

Signed-off-by: Dean Roehrich <[email protected]>
@matthew-richerson
Use clientmountd in nnf-sos
290687d 
clientmountd moved from dws to nnf-sos. Update the daemons.conf file to point to the
new repo and use the correct service account.

Signed-off-by: Matt Richerson <[email protected]>
@matthew-richerson
Merge pull request #104 from NearNodeFlash/clientmountd_move
11cfab5 
Use clientmountd in nnf-sos
@bdevcich
Add daemon env var support; tune daemon garbage collection, max procs…
2869774 
…, & HTTP2 health check

* Added Environment field to daemons to support environment variables in
  systemd overrides file
* Fixed an issue with line endings in the systemd overrides file that caused
  the first Environment field to be ignored
* Added tunings for both daemons

Signed-off-by: Blake Devcich <[email protected]>
@bdevcich
Use master for lustre-csi-driver and lustre-fs-operator + update subm…
8f9794a 
…odules

Signed-off-by: Blake Devcich <[email protected]>
@roehrich-hpe
Toss deprecated build.sh. (#107)
7fde887 
Signed-off-by: Dean Roehrich <[email protected]>
@ajfloeder
Update the system configuration for texas and the submodules (#110)
525da05 
Signed-off-by: Anthony Floeder <[email protected]>
@roehrich-hpe
Move the prometheus helm chart values to a helm-specific subdir (#109)
a5561fd 
Signed-off-by: Dean Roehrich <[email protected]>
@ajfloeder
release v0.0.7
237dfbf 
Signed-off-by: Anthony Floeder <[email protected]>
@ajfloeder
release v0.0.7
b11a781 
Signed-off-by: Anthony Floeder <[email protected]>
bdevcich
bdevcich requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@bdevcich bdevcich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to target the release branch, not master.

@ajfloeder ajfloeder changed the base branch from master to releases/v0 January 16, 2024 19:11
@ajfloeder ajfloeder requested a review from bdevcich January 16, 2024 20:54
bdevcich
bdevcich reviewed Jan 16, 2024
View reviewed changes
config/repositories.yaml Outdated
@@ -33,14 +33,14 @@ repositories:
master: https://ghcr.io/hewlettpackard/lustre-csi-driver
useRemoteK: true
remoteReference:
build: v0.0.6
build: 0.0.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need the v. @roehrich-hpe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@ajfloeder
Correct the build version tag
6c7c489 
Signed-off-by: Anthony Floeder <[email protected]>
@roehrich-hpe
Copy link
Contributor

I cloned a fresh copy of the repo, checked out this PR, and did the ./update.sh. This is what I see for the submodules:

$ git submodule status    
+4b67213ec79a885df815e9ba5fac6a0379db839b dws (v0.0.0-283-g4b67213e)
+e58b06cb55bc91e756ccbb4d9e60abbb8a40a8b6 lustre-csi-driver (v0.0.0-79-ge58b06c)
+eb84599f9630780c902190a281a70564e5221638 lustre-fs-operator (v0.0.0-83-geb84599)
+67f89bd426d1f47799043fe4eea27fca68b16b89 nnf-dm (v0.0.0-198-g67f89bd)
+e25619962e0d5b9e7ff0d4f36178ddc3dbcc0ab1 nnf-integration-test (v0.0.0-61-ge256199)
+871b2caa8c9c45e206fc3728ecc0e993d7a2e362 nnf-sos (v0.0.0-456-g871b2caa)

I was expecting that each one would include the commit that has the annotated tag.

@bdevcich
Copy link
Contributor

I was expecting that each one would include the commit that has the annotated tag.

When I use LLNL's process to checkout this branch, I see the submodules at the right tags:

export NNF_VERSION=v0.0.7
 
git clone --recurse-submodules [email protected]:NearNodeFlash/nnf-deploy nnf-deploy-$NNF_VERSION
cd nnf-deploy-$NNF_VERSION

Since the tag doesn't exist yet, I checkout the release-v0.0.7 branch and update the submodules:

git checkout release-v0.0.7
git submodule update

Then I get all the tags:

$ git submodule status
 071e4187ad6cfebc2ea582be3bec47d2124b75ad dws (v0.0.15)
 daa1cff12120f0aa991015c95b7527ace7f33ea2 lustre-csi-driver (v0.0.7)
 f983003e9a022ea1db56f9d03b89710f2c8110fd lustre-fs-operator (v0.0.7)
 a56e780213dbb73e141f4b2c5676fbea66a40f92 nnf-dm (v0.0.7)
 a3be2b1b63474d85364e0f8493bb43e9c5d29188 nnf-integration-test (v0.0.4)
 226cbe05c4a5e5180ba4d20fc48158ed13291ec0 nnf-sos (v0.1.1)

@roehrich-hpe
Copy link
Contributor

I was expecting that each one would include the commit that has the annotated tag.

When I use LLNL's process to checkout this branch, I see the submodules at the right tags:

Yep, that finds the right stuff.

Gotta be careful with that ./update.sh tool.

@ajfloeder ajfloeder merged commit d0ee6c6 into releases/v0 Jan 17, 2024
1 check passed
@ajfloeder ajfloeder deleted the release-v0.0.7 branch January 17, 2024 00:58
@bdevcich
Copy link
Contributor

Gotta be careful with that ./update.sh tool.

I almost never use it. I usually just do this to update the modules:

git submodule foreach checkout master
git submodule foreach git pull

Not sure if there's a downside to it, but hasn't failed me yet. It's the behavior I would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdevcich bdevcich bdevcich approved these changes

@roehrich-hpe roehrich-hpe roehrich-hpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajfloeder @roehrich-hpe @bdevcich @jameshcorbett @matthew-richerson