Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the upgrade process safer #147

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

karim-en
Copy link
Collaborator

@karim-en karim-en commented Nov 6, 2024

If the migration is missed during the upgrade, it cannot be recovered. Therefore, the contract state will be corrupted, and the upgrade cannot be repeated.
There are two ways to prevent this:

  • Remove the self everywhere from the near-plugins example.
  • Verify the state after migration by default.

The second one is less invasive, so this PR implements it.

@karim-en karim-en requested a review from r-near November 20, 2024 13:02
@karim-en karim-en merged commit 6149e03 into master Nov 28, 2024
2 checks passed
@karim-en karim-en deleted the verify-state-after-upgrade branch November 28, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants