Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: switch to stable Rust toolchain #63

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Feat: switch to stable Rust toolchain #63

merged 5 commits into from
Sep 21, 2023

Conversation

mrLSD
Copy link
Collaborator

@mrLSD mrLSD commented Sep 19, 2023

Description

  • Changed toolchain to stable rust.
  • Removed nightly-specific flags from contract build.
  • Modified github CI.

@mrLSD mrLSD self-assigned this Sep 19, 2023
@mrLSD mrLSD added the enhancement New feature or request label Sep 19, 2023
@mrLSD mrLSD added this to the v0.6.1 milestone Sep 19, 2023
@mrLSD mrLSD requested a review from aleksuss September 19, 2023 14:08
aleksuss
aleksuss approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good with some nitpicks.

.github/workflows/lints.yml Outdated Show resolved Hide resolved
.github/workflows/lints.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
rust-toolchain Show resolved Hide resolved
@mrLSD mrLSD force-pushed the feat/stable-toolchain branch 4 times, most recently from cb3bec1 to e56e31a Compare September 19, 2023 16:26
aleksuss
aleksuss reviewed Sep 19, 2023
View reviewed changes
rust-toolchain Outdated Show resolved Hide resolved
@mrLSD mrLSD force-pushed the feat/stable-toolchain branch from e56e31a to cd5ee00 Compare September 19, 2023 18:55
@mrLSD mrLSD force-pushed the feat/stable-toolchain branch from cd5ee00 to 3079fa2 Compare September 19, 2023 18:59
@mrLSD mrLSD merged commit 1a95a10 into master Sep 21, 2023
6 checks passed
@mrLSD mrLSD deleted the feat/stable-toolchain branch September 21, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksuss aleksuss aleksuss approved these changes

Assignees

@mrLSD mrLSD

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mrLSD @aleksuss