Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: remove doposit-event field #36

Merged
merged 4 commits into from
May 10, 2023
Merged

Feat: remove doposit-event field #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7372701
Remove doposit-event field
mrLSD May 10, 2023
d04ad4c
Remove doposit-event field from tests
mrLSD May 10, 2023
b772b04
Clean comment
mrLSD May 10, 2023
f6c9f82
Cleanup
mrLSD May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eth-connector-tests/src/connector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,6 @@ async fn test_deposit_with_0x_prefix() -> anyhow::Result<()> {
sender: Address::zero(),
token_message_data,
amount: deposit_amount,
fee,
};

let event_schema = ethabi::Event {
Expand All @@ -528,7 +527,7 @@ async fn test_deposit_with_0x_prefix() -> anyhow::Result<()> {
data: ethabi::encode(&[
ethabi::Token::String(message),
ethabi::Token::Uint(U256::from(deposit_event.amount)),
ethabi::Token::Uint(U256::from(deposit_event.fee.as_u128())),
ethabi::Token::Uint(U256::from(fee.as_u128())),
]),
};
let proof = Proof {
Expand Down
3 changes: 1 addition & 2 deletions eth-connector-tests/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,6 @@ impl TestContract {
sender: Address::new(H160([0u8; 20])),
token_message_data,
amount: deposit_amount,
fee,
};

let event_schema = ethabi::Event {
Expand All @@ -348,7 +347,7 @@ impl TestContract {
data: ethabi::encode(&[
ethabi::Token::String(message),
ethabi::Token::Uint(U256::from(deposit_event.amount)),
ethabi::Token::Uint(U256::from(deposit_event.fee.as_u128())),
ethabi::Token::Uint(U256::from(fee.as_u128())),
]),
};
Proof {
Expand Down
2 changes: 0 additions & 2 deletions eth-connector/src/deposit_event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ pub struct DepositedEvent {
pub sender: Address,
pub token_message_data: TokenMessageData,
pub amount: Balance,
pub fee: Fee,
}

impl DepositedEvent {
Expand Down Expand Up @@ -314,7 +313,6 @@ impl DepositedEvent {
sender,
token_message_data,
amount,
fee,
})
}
}
Expand Down