Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-pdf] 미지원 글꼴 지원 (cmap) 및 font overriding 대응 이슈 확인 #30

Closed
2-one-week opened this issue Apr 28, 2024 · 8 comments
Closed

[react-pdf] 미지원 글꼴 지원 (cmap) 및 font overriding 대응 이슈 확인 #30

2-one-week opened this issue Apr 28, 2024 · 8 comments
Assignees
@yceffort-naver

Comments

@2-one-week
Copy link
Member

  • canvas, svg를 그릴 때, font 글씨체를 그리기 위해서는 var character = glyph.unicode || glyph.fontChar; 글꼴 처리를 하고 있습니다.

    • 네이버 앱에서 폰트를 강제로 오버라이딩한 경우, glyph fontChar가 제대로 들어오지 않아 생기는 이슈로 unicode를 보도록 수정한 이슈입니다.
    • 기본적으로 unicode도 같이 들어오고 있기 때문에, 폰트 볼드 및 강조 처리등이 누락되고 있습니다.
    • 의사 결정이 필요합니다..

  • 왼쪽이 unicode로 렌더링된 결과 / 오른쪽이 원래 pdf 입니다

image
@2-one-week
Copy link
Member Author

폰트 가져오는 부분 : https://github.com/NaverPayDev/pie/blob/epic/react_pdf/packages/react-pdf/src/pdfjs-dist/legacy/build/pdf.worker.js#L36865-L36914

charCode가 망가진 경우에만 unicode를 보도록 수정해야 모든걸 만족시키면서 렌더링이 가능

@yceffort-naver yceffort-naver self-assigned this Apr 29, 2024
@yceffort-naver
Copy link
Contributor

image

@2-one-week
Copy link
Member Author

관련 이슈 : mozilla/pdf.js#10205

@yceffort-naver
Copy link
Contributor

버전업으로 해결된다면 대략 난감.. IE 지원 멈춰...

@2-one-week
Copy link
Member Author

버전업으로 해결된다면 대략 난감.. IE 지원 멈춰...

버전업되어 반영된 코드를 넣어도 똑같습니다..ㅠ

@yceffort-naver
Copy link
Contributor

mozilla/pdf.js#1914 (comment) ...

@yceffort-naver
Copy link
Contributor

image

yceffort-naver added a commit that referenced this issue May 16, 2024
@yceffort-naver
[#30] 🐛 폰트 이슈를 수정합니다.
8e95cd5
yceffort-naver added a commit that referenced this issue May 16, 2024
@yceffort-naver
[#30] 🔥 remove useless code
8c981ab
2-one-week pushed a commit that referenced this issue May 17, 2024
@yceffort-naver @2-one-week
[#30] 🐛 폰트 이슈를 수정합니다.
437d136
2-one-week pushed a commit that referenced this issue May 17, 2024
@yceffort-naver @2-one-week
[#30] 🔥 remove useless code
cd6883f
@2-one-week
Copy link
Member Author

작업 감사드립니다!

2-one-week pushed a commit that referenced this issue May 17, 2024
@yceffort-naver @2-one-week
[#30] 🐛 폰트 이슈를 수정합니다.
edbf813
2-one-week pushed a commit that referenced this issue May 17, 2024
@yceffort-naver @2-one-week
[#30] 🔥 remove useless code
ac9414f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yceffort-naver yceffort-naver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@2-one-week @yceffort-naver