Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set drive state minor issue #12

Closed
ulmitov opened this issue Apr 21, 2023 · 4 comments
Closed

Set drive state minor issue #12

ulmitov opened this issue Apr 21, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ulmitov
Copy link

ulmitov commented Apr 21, 2023

Hi,

When setting drive.state= 'good' it fails (i don't have an output to paste right now)
since there is no 'good' state, only 'ugood' or 'unconfigured good'
while drive.state = 'offline''missing''online' works well, it makes a little confusion

Thanks

@ralequi
Copy link
Member

ralequi commented Apr 21, 2023

hmm, the state setter expects a "valid state" in the raw str that storcli expects or, a DriveState valid enum.

I'm checking and maybe forcing to convert into DriveState may fix your issue

ralequi added a commit that referenced this issue Apr 21, 2023
@ralequi ralequi self-assigned this Apr 21, 2023
@ralequi ralequi added the enhancement New feature or request label Apr 21, 2023
@ralequi
Copy link
Member

ralequi commented May 8, 2023

Is this issue fixed? I checked there were a commit a few weeks ago but don't remember if enough or not

@ulmitov
Copy link
Author

ulmitov commented May 8, 2023

Didn't check this one, but the code looks totally correct

@ralequi
Copy link
Member

ralequi commented Jun 1, 2023

Ok, I'm closing this for now...

Reopen if you find it fails again please.

Thanks!

@ralequi ralequi closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants