Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type to Builder.build method #667

Conversation

jreitz-voffice
Copy link

Purpose / Goal

Add return type to Builder.build method so the output is typed when using.

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • [] New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

Copy link

guardrails bot commented Aug 9, 2024

⚠️ We detected 8 security issues in this pull request:

Vulnerable Libraries (8)
Severity Details
Medium pkg:npm/[email protected] (t) upgrade to: 1.6.0
High pkg:npm/[email protected] (t) upgrade to: 3.0.3
High pkg:npm/[email protected] (t) upgrade to: 3.0.3
High pkg:npm/[email protected] (t) upgrade to: 3.1.0
Medium pkg:npm/[email protected] (t) - no patch available
High pkg:npm/[email protected] (t) upgrade to: 2.2.2
Medium pkg:npm/[email protected] (t) upgrade to: 4.17.21
Medium pkg:npm/[email protected] (t) upgrade to: 7.5.2

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@coveralls
Copy link

Coverage Status

coverage: 98.175%. remained the same
when pulling e8e2f43 on jreitz-voffice:define-returntype-builder
into d40e29c on NaturalIntelligence:master.

Copy link
Member

@amitguptagwl amitguptagwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only code change is acceptable. config change or other files are prohibited from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants