Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute controls feature #181

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Conversation

helloWorld199
Copy link
Contributor

@helloWorld199 helloWorld199 commented Jun 22, 2024


📚 Documentation preview 📚: https://miditok--181.org.readthedocs.build/en/181/

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 92.88991% with 31 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (5b3c3f6) to head (55273ee).
Report is 5 commits behind head on main.

Current head 55273ee differs from pull request most recent head 3cfda40

Please upload reports for the commit 3cfda40 to get more accurate results.

Files Patch % Lines
miditok/attribute_controls/classes.py 92.10% 6 Missing ⚠️
miditok/tokenizer_training_iterator.py 37.50% 5 Missing ⚠️
tests/utils_tests.py 88.09% 5 Missing ⚠️
...tok/attribute_controls/track_attribute_controls.py 95.00% 4 Missing ⚠️
miditok/tokenizations/midi_like.py 20.00% 4 Missing ⚠️
tests/test_attribute_controls.py 95.74% 2 Missing ⚠️
miditok/midi_tokenizer.py 98.21% 1 Missing ⚠️
miditok/tokenizations/mmm.py 80.00% 1 Missing ⚠️
miditok/tokenizations/mumidi.py 75.00% 1 Missing ⚠️
miditok/tokenizations/octuple.py 83.33% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   90.46%   90.58%   +0.12%     
==========================================
  Files          35       40       +5     
  Lines        5525     6024     +499     
==========================================
+ Hits         4998     5457     +459     
- Misses        527      567      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

miditok/attribute_controls/__init__.py Outdated Show resolved Hide resolved
miditok/attribute_controls/track_attribute_controls.py Outdated Show resolved Hide resolved
miditok/midi_tokenizer.py Outdated Show resolved Hide resolved
miditok/midi_tokenizer.py Outdated Show resolved Hide resolved
miditok/attribute_controls/__init__.py Outdated Show resolved Hide resolved
miditok/attribute_controls/classes.py Outdated Show resolved Hide resolved
docs/attribute_controls.rst Show resolved Hide resolved
tests/test_attribute_controls.py Outdated Show resolved Hide resolved
tests/test_attribute_controls.py Outdated Show resolved Hide resolved
miditok/attribute_controls/classes.py Outdated Show resolved Hide resolved
@Natooz Natooz merged commit f9701b8 into Natooz:main Jun 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants