Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default continuing_subword_prefix when splitting token sequences #168

Merged
merged 5 commits into from
May 13, 2024

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented May 13, 2024

  • fixing end_suffix arg for WordPiece (as training is identical to BPE)

📚 Documentation preview 📚: https://miditok--168.org.readthedocs.build/en/168/

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.45%. Comparing base (c2c8cb3) to head (323b82c).
Report is 10 commits behind head on main.

❗ Current head 323b82c differs from pull request most recent head f31d12e. Consider uploading reports for the commit f31d12e to get more accurate results

Files Patch % Lines
miditok/midi_tokenizer.py 95.23% 2 Missing ⚠️
tests/test_train.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   91.06%   90.45%   -0.61%     
==========================================
  Files          35       35              
  Lines        5214     5524     +310     
==========================================
+ Hits         4748     4997     +249     
- Misses        466      527      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz merged commit 62c72c7 into main May 13, 2024
12 checks passed
@Natooz Natooz deleted the tok-train-suffix branch May 13, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant