Fix comparison with NAN in heatmap.py #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengky-kurniawan-1
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR resolves #28, where the use of
np.NANinheatmap.pycauses anAttributeErrorin NumPy version 2.1. To resolve this, all instances ofnp.NANare replaced withnp.nan, ensuring compatibility with both current and future versions of NumPy, as recommended by the NumPy stable documentation and the NumPy 1.26 documentation.Current Behavior
Using
np.NANresults inAttributeError: module 'numpy' has no attribute 'NAN', causing errors in NumPy 2.1.Expected Behavior
The code will now use
np.nanfor NaN handling, eliminating theAttributeErrorand ensuring compatibility across NumPy versions.