Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execSync crashes process with custom shell on Windows #121

Closed
petekanev opened this issue Mar 28, 2017 · 1 comment
Closed

execSync crashes process with custom shell on Windows #121

petekanev opened this issue Mar 28, 2017 · 1 comment
Assignees
Milestone

Comments

@petekanev
Copy link
Contributor

petekanev commented Mar 28, 2017

Changes introduced with PR #118 cause a crash on Windows when a non default shell is used (git bash).

Mine is located in C:/Program Files/Git/.... for example, and the path contains whitespaces, resulting in the following error output:

[NativeScriptCli] execute: tns --version
Error: Command failed: tns --version
/c/Program: Files\Git\usr\bin\bash: No such file or directory
Error: NativeScript CLI not found. Use 'nativescript.tnsPath' workspace setting to explicitly set the absolute path to the NativeScript CLI.

It is a known node.js issue - nodejs/node#6803

@petekanev petekanev added this to the 0.7.0 milestone Mar 28, 2017
@petekanev petekanev self-assigned this Mar 28, 2017
@petekanev
Copy link
Contributor Author

petekanev commented Mar 28, 2017

I propose a fix for Windows that will always default to the cmd.exe (just as it has been before 0.7).

I have not tested whether having a whitespace in the path to the default shell on a Unix OS will produce the same node error, though based on the original node issue - it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants