Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to pass custom ndkVersion to the runtime #1671

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

farfromrefug
Copy link
Contributor

@FestplattenSchnitzel This answer the need for this PR #1670

Instead of fixing the version i went for allowing to set it through command line.
You can then build the android runtime like this:
./gradlew -PndkVersion=20.1.5948944

@FestplattenSchnitzel why version 20.x and not 21.x ? I understand 22 might be too new but 21 should be good, right?
I just want to make sure we use a recent ndk for the runtime. I dont want any crash to appear on f-droid as we would be using an old ndk (which the dev would not know about as he builds with a newer one)

@FestplattenSchnitzel
Copy link

@farfromrefug when building locally on my machine Gradle automatically used NDK version 20.0.5594570. But if you're sure that 21.x works, we can use that one.

I dont want any crash to appear on f-droid as we would be using an old ndk (which the dev would not know about as he builds with a newer one)

I don't like crashed either, but every version built by the F-Droid test CI so far worked perfectly fine, so the chances seem to be good.

@farfromrefug
Copy link
Contributor Author

@FestplattenSchnitzel it is not a question of me being sure it is good. As we dont define it right now it is gradle which chooses it. So it must often be quite recent.

@lambourn
Copy link

maybe related:
#1659

@triniwiz triniwiz changed the base branch from master to 8.2.0 September 28, 2021 07:26
@triniwiz triniwiz merged commit a905b0e into NativeScript:8.2.0 Sep 28, 2021
@farfromrefug
Copy link
Contributor Author

@FestplattenSchnitzel will be released with the runtime 8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants