fix: allow to pass custom ndkVersion to the runtime #1671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FestplattenSchnitzel This answer the need for this PR #1670
Instead of fixing the version i went for allowing to set it through command line.
You can then build the android runtime like this:
./gradlew -PndkVersion=20.1.5948944
@FestplattenSchnitzel why version 20.x and not 21.x ? I understand 22 might be too new but 21 should be good, right?
I just want to make sure we use a recent ndk for the runtime. I dont want any crash to appear on f-droid as we would be using an old ndk (which the dev would not know about as he builds with a newer one)