Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application-settings): implemented allKeys method #6371

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

surdu
Copy link
Contributor

@surdu surdu commented Oct 8, 2018

PR Checklist

What is the current behavior?

There is no way to get all key from application-settings.

What is the new behavior?

There is a method .allKeys() that returns all the keys from application-settings.

Fixes #6210.

@ghost ghost added the ♥ community PR label Oct 8, 2018
@ns-bot ns-bot added the cla: yes label Oct 8, 2018
@vakrilov
Copy link
Contributor

vakrilov commented Oct 8, 2018

Hey @surdu - Thanks for the PR!

@vakrilov
Copy link
Contributor

vakrilov commented Oct 8, 2018

test

@surdu
Copy link
Contributor Author

surdu commented Oct 8, 2018

@vakrilov Hey! My pleasure 😉

@ghost ghost assigned vakrilov Oct 9, 2018
@ghost ghost added in progress and removed ♥ community PR labels Oct 9, 2018
@vakrilov
Copy link
Contributor

test

@vakrilov vakrilov merged commit 829d18b into NativeScript:master Oct 12, 2018
@ghost ghost removed the in progress label Oct 12, 2018
@surdu surdu deleted the all-keys branch October 12, 2018 12:23
@radeva
Copy link

radeva commented Nov 19, 2018

Hi @surdu ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

@surdu
Copy link
Contributor Author

surdu commented Nov 19, 2018

O, wow! That's awesome! Thank you 😁

@lock
Copy link

lock bot commented Nov 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application-settings: access all keys
4 participants