Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow crossbuilding + minor DRY cleanup #79

Merged
merged 15 commits into from
Apr 27, 2024
Merged

allow crossbuilding + minor DRY cleanup #79

merged 15 commits into from
Apr 27, 2024

Conversation

Rudeisnice
Copy link
Contributor

@Rudeisnice Rudeisnice commented Sep 19, 2023 •
edited
Loading

  • Fixes serving on Windows without braking any other platform.
  • Removed php executable copy inside electron-builder.
  • php.js differentiates between serving and building

@Rudeisnice Rudeisnice changed the title Windows serve fix and extra conditions to check for serve or building Updated electron-builder to crosscompile to a Windows target. Sep 24, 2023
@Rudeisnice Rudeisnice changed the title Updated electron-builder to crosscompile to a Windows target. Updated electron-builder to crosscompile to a Windows target. Minor fixes for building on mac Sep 24, 2023
@Rudeisnice Rudeisnice marked this pull request as ready for review September 24, 2023 22:18
@Rudeisnice Rudeisnice changed the title Updated electron-builder to crosscompile to a Windows target. Minor fixes for building on mac allow crossbuilding + minor DRY cleanup Oct 31, 2023
sweptsquash added a commit to sweptsquash/electron-ci that referenced this pull request Dec 1, 2023
@sweptsquash
chore: Add PR NativePHP#74 and PR NativePHP#79 for use in personal pr…
5fc062c 
…oject
@AlexJanson AlexJanson mentioned this pull request Jan 3, 2024
Closed
@timo-de-winter
Copy link

This fixed my building issues! Thanks so much <3.

@simonhamp simonhamp mentioned this pull request Apr 2, 2024
Closed
@simonhamp
Copy link
Member

This is great @Rudeisnice. Thank you

@simonhamp simonhamp merged commit ba14675 into NativePHP:main Apr 27, 2024
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rudeisnice @timo-de-winter @simonhamp