Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AccumuloSyntaxParserConstants class so it is not an interface #2739

Open
lbschanno opened this issue Feb 6, 2025 · 0 comments · May be fixed by #2740
Open

Refactor AccumuloSyntaxParserConstants class so it is not an interface #2739

lbschanno opened this issue Feb 6, 2025 · 0 comments · May be fixed by #2740
Assignees
@lbschanno

Comments

@lbschanno
Copy link
Collaborator

Refactor AccumuloSyntaxParserConstants so that it is not an interface, but rather a final, uninstantiable class with defined constants.
@lbschanno lbschanno self-assigned this Feb 6, 2025
lbschanno added a commit that referenced this issue Feb 6, 2025
@lbschanno
Refactor AccumuloSyntaxParserConstants so it is not an interface
35ee1f8 
Refactor AccumuloSyntaxParserConstants so that it is not an interface
that consists solely of constants, but is rather a final, uninstantiable
class with constants. While not strictly an issue, it is odd for
AccumuloSyntaxParser and AccumuloSyntaxParserTokenManager to both be
considered implementations of AccumuloSyntaxParserConstants.

Closes #2739
@lbschanno lbschanno linked a pull request Feb 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbschanno lbschanno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor AccumuloSyntaxParserConstants so it is not an interface NationalSecurityAgency/datawave
1 participant
@lbschanno