Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contents-dialog should now resize on objects without toc #436

Conversation

jimarthurnilsen
Copy link
Contributor

@jimarthurnilsen jimarthurnilsen commented Dec 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

If content dialog stretches longer than viewport it doesn't resize if it's an object without toc, until a CD is triggered by hovering the close button

Issue Number: N/A

What is the new behavior?

contents dialog now correctly resizes on objects without toc

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fab6832. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@ronnymikalsen ronnymikalsen merged commit 52da246 into NationalLibraryOfNorway:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants