Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close dialogs when switching to page mode #172

Closed
ronnymikalsen opened this issue Oct 30, 2017 · 0 comments
Closed

Close dialogs when switching to page mode #172

ronnymikalsen opened this issue Oct 30, 2017 · 0 comments
Assignees
@ronnymikalsen
Labels
bug has pr P4: minor

Comments

@ronnymikalsen
Copy link
Collaborator

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Contents and search dialog should close when user is switching to page mode

What is the current behavior?

Dialog is not closing

What are the steps to reproduce?

  1. Open a publication
  2. Switch to dashboard mode
  3. Click on "Contents" button
  4. Select a page

What is the use-case or motivation for changing an existing behavior?

Better UX

Which versions of Angular, OS, TypeScript, browsers are affected?

Is there anything else we should know?

This behaviour was not present in a earlier version
@ronnymikalsen ronnymikalsen self-assigned this Oct 31, 2017
ronnymikalsen added a commit to ronnymikalsen/ngx-mime that referenced this issue Oct 31, 2017
@ronnymikalsen
fix: close dialogs when switching to page mode
f2d67e4 
This feature was commented out by a mistake

Fixes NationalLibraryOfNorway#172
ronnymikalsen added a commit to ronnymikalsen/ngx-mime that referenced this issue Oct 31, 2017
@ronnymikalsen
fix: close dialogs when switching to page mode
eedc83f 
This feature was commented out by a mistake

Fixes NationalLibraryOfNorway#172
@ronnymikalsen ronnymikalsen mentioned this issue Oct 31, 2017
Merged
raymondkarstensen pushed a commit that referenced this issue Nov 1, 2017
@ronnymikalsen @raymondkarstensen
fix: close dialogs when switching to page mode (#175)
967dc89 
This feature was commented out by a mistake

Fixes #172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronnymikalsen ronnymikalsen

Labels
bug has pr P4: minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronnymikalsen