Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix AVITI demux script #395

Merged

Conversation

kedhammar
Copy link

This file is quite old and complex (13 levels of indentation yay!) but I've attempted to make a simple bugfix by skipping outputs that do not contain the relevant sample name.

@kedhammar
Copy link
Author

The new code was run manually on this step
https://ngi-lims-prod.scilifelab.se/clarity/work-details/1153994

@kedhammar kedhammar self-assigned this Feb 6, 2025
@kedhammar kedhammar added the bug label Feb 6, 2025
@kedhammar
Copy link
Author

The impact is a bit spooky, but hopefully the change is small and simple enough not to warrant a validation / verification @alneberg @parlundin

Copy link

@ssjunnebo ssjunnebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kedhammar kedhammar merged commit 077b273 into NationalGenomicsInfrastructure:master Feb 18, 2025
8 checks passed
@kedhammar kedhammar deleted the aviti-demux-fix branch February 18, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants