Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVITI manifest fixes #393

Merged

Conversation

kedhammar
Copy link

  • Tweak settings section to allow for identical I1 xor I2
  • Trim down PhiX indices in PhiX manifest based on supplied run recipe

Copy link

@ssjunnebo ssjunnebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think! 👍

@kedhammar
Copy link
Author

Ok, ready for review now @ssjunnebo

Copy link

@ssjunnebo ssjunnebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this code, but looks good to me 👍

@kedhammar kedhammar merged commit 7b39e61 into NationalGenomicsInfrastructure:master Feb 11, 2025
8 checks passed
@kedhammar kedhammar deleted the aviti-trim-phix branch February 11, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants