Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability improvements #84

Conversation

kedhammar
Copy link
Collaborator

No description provided.

@kedhammar kedhammar requested a review from remiolsen May 28, 2024 09:29
@kedhammar kedhammar requested a review from alneberg May 30, 2024 12:57
@kedhammar kedhammar marked this pull request as ready for review May 30, 2024 12:58
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement!

@kedhammar kedhammar merged commit 519f74b into NationalGenomicsInfrastructure:master Jun 10, 2024
6 checks passed
Copy link
Member

@remiolsen remiolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Thanks for cleaning up my idiosyncratic variable names! 🙇
  2. I really need to start using type hints myself
  3. 👍

@kedhammar kedhammar deleted the readability-improvements branch June 11, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants