Refactor/ss3 #49
Merged
Refactor/ss3 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
lib/realms/smartseq3module, focusing on improving logging and refining file path initialization. The most important changes are summarized below:Logging improvements:
lib/realms/smartseq3/ss3_sample.py: Added a status update to indicate the start of the pre-processing step and included a TODO comment suggesting the addition of decorators for logging method start and end times.File path initialization refinement:
lib/realms/smartseq3/utils/sample_file_handler.py: Updated the report file path to include "SS3" in the filename, ensuring consistency with the agreed format expected by Genstat.