Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-all): update to Angular 7 + TypeScript 3.1 #872

Conversation

SuperITMan
Copy link
Member

@SuperITMan SuperITMan commented Nov 20, 2018

Remove --no-optional param
Remove Node6 support. Add Node10 Support.
Update engines for each package

ISSUES CLOSED: #871

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #871

What is the new behavior?

The following deps have been updated:

  • @angular/... : 7.x
  • @ngx-translate/core: 11.0.1
  • @ngrx/...: 7.0.0-beta.0
  • typescript: 3.1

Tsickle dependency has been added in the root of the project because it has been removed from the deps of @angular/compiler-cli. Tsickle is needed in our build process.

The param --no-optional has been removed in the install scripts to improve cross-platform usage of the project (ie: on Windows and Linux, fsevents is not used but it is used on MacOS. It should be part of the package-lock.json file as optional dependency).

The rule "no-unused-variable": true has been removed from tslint.json because now it is part of TypeScript 3. See palantir/tslint#4046 for more info.

The tests of the project are now runned with Node10 in replacement of Node8.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added comp: stark-all To apply for all Stark modules type: feature labels Nov 20, 2018
@SuperITMan SuperITMan added this to the 10.0.0-beta.2 milestone Nov 20, 2018
Copy link
Collaborator

@christophercr christophercr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change this too:

  • remove all angular related deps from greenkeeper.json
  • change the version of all ngrx packages to version 7 beta 0

@SuperITMan SuperITMan force-pushed the feature/update-angular-7-typescript-3 branch from 03ebb78 to 51a6c1b Compare November 20, 2018 19:26
@coveralls
Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage increased (+0.01%) to 93.566% when pulling edd108d on SuperITMan:feature/update-angular-7-typescript-3 into fc4a5f5 on NationalBankBelgium:master.

@SuperITMan SuperITMan force-pushed the feature/update-angular-7-typescript-3 branch 4 times, most recently from 8f0492d to d39ff8a Compare November 21, 2018 09:49
Remove --no-optional param
Remove Node6 support. Add Node10 Support.
Update engines for each package

ISSUES CLOSED: #871
@SuperITMan SuperITMan force-pushed the feature/update-angular-7-typescript-3 branch from d39ff8a to edd108d Compare November 21, 2018 10:24
@SuperITMan SuperITMan merged commit c414f9b into NationalBankBelgium:master Nov 21, 2018
@SuperITMan SuperITMan deleted the feature/update-angular-7-typescript-3 branch November 21, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: stark-all To apply for all Stark modules type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: upgrade to NG7
4 participants