-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stark-testing): create separate stark-testing package and use it in all stark packages and starter #267
Conversation
…Upgrade @types/node in all packages
// const ROOT = path.resolve(__dirname, '..'); | ||
const _root = path.resolve(process.cwd(), "."); // project root folder | ||
|
||
const root = path.join.bind(path, _root); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not put a peerDependency on @nbb/stark-build and use helpers directly from stark-build ?
Except if we only plan to use root(). But maybe later for e2e we will use other methods already defined stark-build/config/helpers.js.
What do you think about that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the idea is to make Stark as flexible as possible, so normally all the testing tooling is just a decision we made in Stark and should not have any impact in the final users of Stark (install our deps in their project) if they decide use another tooling.
So, we should keep this package as independent as possible, because again, Stark is really flexible and the stark-build might not be the package selected by the user to build their app...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, we can review this later once we have a better view on how all our packages will be used in a client app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me
Ok, I've resolved the conflicts so this PR can be merged now ;) |
Fixes #68
So that our unit-testing tooling is optional for the end users (they might want to use tape or what not).
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Unit testing is done using Webpack and including all unit-testing specific dependencies in all the packages that include unit tests.
Issue Number: #68 #84 #93
What is the new behavior?
stark-testing
package includes all tooling needed to run unit tests in stark packages so these packages only need a dependency tostark-testing
(by the relative folder path instead of a tgz package)Does this PR introduce a breaking change?
Other information
Renamed all
build:stark-xxxx
andclean:stark-xxxx
scripts to remove the 'stark-' prefix and keep consistency with the rest of scripts.