Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-ui): route-search - add support for partial matching #1554

Conversation

SuperITMan
Copy link
Member

ISSUES CLOSED: #1335

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There is no support for partial matching in StarkRouteSearchComponent.

Issue Number: #1335

What is the new behavior?

The route-search component now supports the partial matching.
Typing 'logou' proposes the route 'App Logout'.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.069% when pulling c9802d7 on SuperITMan:feature/stark-ui-improve-route-search-component into d90bc5e on NationalBankBelgium:master.

Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@nicanac nicanac merged commit 77fd03e into NationalBankBelgium:master Jan 20, 2020
@SuperITMan SuperITMan deleted the feature/stark-ui-improve-route-search-component branch January 20, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page search component is not very friendly
3 participants