-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stark-ui): update some component styling to fix bugs #1171
fix(stark-ui): update some component styling to fix bugs #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
764ee3b
to
5b980f0
Compare
@christophercr I updated the PR. I also needed to change some CSS of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now although the issue on IE is solved, as I showed you there are 2 issues:
5b980f0
to
53aeddb
Compare
@christophercr I updated the PR and added #1172 😄 |
Now Travis is failing because of this error on the unit tests of the Showcase:
|
53aeddb
to
13e77cf
Compare
@christophercr I updated the PR 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed, the regression caused in the Table of Contents will be tackled in #1172 which has a lower priority that the issue solved in this PR ;)
- fix footer overflow - fix footer hovering above bottom of screen - removed unused redundant DOM from `app.component.html` (showcase / starter) ISSUES CLOSED: NationalBankBelgium#1169 BREAKING CHANGES: - `stark-app-sidenav-content` should not be applied to a wrapper element (`div`) anymore. Replace it with a `ng-container`. This ensures the footer is always at the bottom. (see Starter for an example) - the css selector for `.stark-main-container` has changed and can now be applied directly to the `main` element in app.component.html. (see Starter for an example)
- improved styling
13e77cf
to
01257d9
Compare
app.component.html
(showcase / starter)PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1169
What is the new behavior?
Footer sticks to bottom.
Does this PR introduce a breaking change?
stark-app-sidenav-content
should not be applied to a wrapper element (div
) anymore. Replace it with ang-container
.This ensures the footer is always at the bottom. (see Starter for an example)