fix(stark-core): use custom encoder for URL query parameters #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophercr
suggested changes
Feb 13, 2019
packages/stark-core/src/modules/http/entities/custom-encoder.ts
Outdated
Show resolved
Hide resolved
packages/stark-core/src/modules/http/services/http.service.spec.ts
Outdated
Show resolved
Hide resolved
carlo-nomes
force-pushed
the
fix/url-encode-plus
branch
2 times, most recently
from
4986a51 to
8a96068
Compare
|
@christophercr I updated the PR. |
- added `http-util` as util for http module
- added `convertStarkQueryParamsIntoHttpParams` function to correctly handle params in the http module
- test `http-util`
- extracted `convertMapIntoObject` function to separate helper file
- added `StarkHttpParameterCodec` as fix
- see: angular/angular#18261 (comment)
- updated tests in `http.service.spec.ts` according to new implementation
ISSUES CLOSED: NationalBankBelgium#1130
carlo-nomes
force-pushed
the
fix/url-encode-plus
branch
from
8a96068 to
b55ca8b
Compare
christophercr
approved these changes
Feb 13, 2019
christophercr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convertMapIntoObjectfunction to separate fileconvertStarkQueryParamsIntoHttpParamsfunction to correctly handle params in the http moduleHttpParameterCodecaccording to this solutionhttp.util.spec.tsaccording to new implementationconvertStarkQueryParamsIntoHttpParamsISSUES CLOSED: #1130
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1130
What is the new behavior?
Encodes special characters correctly
Does this PR introduce a breaking change?