Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the mkdirp code in the starter scripts server:dev & build:dev #356

Closed
tenretC opened this issue May 7, 2018 · 3 comments
Closed

Comments

@tenretC
Copy link
Contributor

tenretC commented May 7, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

There is an issue with the way webpack-monitor generate the folder for its reports.
I'll fix this by adding npx mkdirp reports to server:dev & build:dev scripts, but it should be removed when this issue is fixed.
NB : this only concerns the dev mode (webpack-monitor is only defined in the webpack.dev config)

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z
Stark version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@tenretC tenretC changed the title remove the mkdirp code in the starter scripts remove the mkdirp code in the starter script server:dev May 7, 2018
tenretC added a commit to tenretC/stark that referenced this issue May 7, 2018
tenretC added a commit to tenretC/stark that referenced this issue May 7, 2018
@tenretC tenretC changed the title remove the mkdirp code in the starter script server:dev remove the mkdirp code in the starter scripts server:dev & build:dev May 7, 2018
@dsebastien
Copy link
Contributor

Did you also create an issue on webpack monitor that we could also track for a cleaner fix?

tenretC added a commit to tenretC/stark that referenced this issue May 8, 2018
@tenretC
Copy link
Contributor Author

tenretC commented May 8, 2018

Yes ;)
But thanks to Alexis I've done something much cleaner so I can close this issue
See #358

@tenretC tenretC closed this as completed May 8, 2018
@dsebastien
Copy link
Contributor

Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants