Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: table - When data is NOT set at the initialization, the table component is NOT built correctly #1087

Closed
SuperITMan opened this issue Jan 29, 2019 · 0 comments · Fixed by #1168
Closed

ui: table - When data is NOT set at the initialization, the table component is NOT built correctly #1087

SuperITMan opened this issue Jan 29, 2019 · 0 comments · Fixed by #1168
Labels
comp: stark-ui type: bug
Milestone
10.0.0-beta.6

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

If no data is set at the initialization of stark-table, the component is broken and changes on data are not applied.

<stark-table [data]="undefined"></stark-table>

Expected behavior

The stark-table component should work even if there is no data at the initialization time.
@SuperITMan SuperITMan added this to the 10.0.0-beta.3 milestone Jan 29, 2019
@carlo-nomes carlo-nomes self-assigned this Mar 4, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 4, 2019
@carlo-nomes
fix(stark-ui): fix table error when data not initialized
7bb4c38 
  - added test
    - refactored test typing

ISSUES CLOSED: NationalBankBelgium#1087
@carlo-nomes carlo-nomes mentioned this issue Mar 4, 2019
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 5, 2019
@carlo-nomes
fix(stark-ui): fix table error when data not initialized
e084278 
  - added test

ISSUES CLOSED: NationalBankBelgium#1087
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 6, 2019
@carlo-nomes
fix(stark-ui): fix table error when data not initialized
9b9e954 
  - added test

ISSUES CLOSED: NationalBankBelgium#1087
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 7, 2019
@carlo-nomes
fix(stark-ui): fix table error when data not initialized
d78ac80 
  - added test

ISSUES CLOSED: NationalBankBelgium#1087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
None yet
Milestone
10.0.0-beta.6
Development

Successfully merging a pull request may close this issue.

fix(stark-ui): fix table error when data not initialized carlo-nomes/stark
3 participants
@christophercr @SuperITMan @carlo-nomes