Skip to content

Commit

Permalink
pkp#2163 Remove obsolete references tto skipWhenVisibleModals option.
Browse files Browse the repository at this point in the history
This option was related to the old jQueryUI dialogs.
  • Loading branch information
NateWr committed Jan 9, 2017
1 parent 4ca7186 commit f4969b3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
15 changes: 0 additions & 15 deletions js/controllers/SiteHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -437,13 +437,10 @@
* @param {{
* container: jQueryObject,
* callback: Function,
* skipWhenVisibleModals: boolean
* }} eventParams The event parameters.
* - container: a jQuery element to be used to test if user click
* outside of it or not.
* - callback: a callback function in case test is true.
* - skipWhenVisibleModals: boolean flag to tell whether skip the
* callback when modals are visible or not.
*/
$.pkp.controllers.SiteHandler.prototype.callWhenClickOutsideHandler_ =
function(sourceElement, event, eventParams) {
Expand Down Expand Up @@ -490,7 +487,6 @@
* option avoids it, use the callback.
* @private
* @param {{
* skipWhenVisibleModals: boolean,
* container: Object,
* callback: Function
* }} checkOptions Object with data to be used to
Expand Down Expand Up @@ -518,17 +514,6 @@
return false;
}

// Check for the visible modals option.
if (checkOptions.skipWhenVisibleModals !==
undefined) {
if (checkOptions.skipWhenVisibleModals) {
if (this.getHtmlElement().find('div.ui-dialog').length > 0) {
// Found a modal, return.
return false;
}
}
}

// Do the click origin checking.
if ($container.has(event.target).length === 0) {

Expand Down
1 change: 0 additions & 1 deletion js/controllers/form/MultilingualInputHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@
this.trigger('callWhenClickOutside', {
container: this.getHtmlElement(),
callback: this.callbackWrapper(this.hidePopover_),
skipWhenVisibleModals: false
});

this.showPopover_();
Expand Down
1 change: 0 additions & 1 deletion js/pages/header/TasksHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
this.trigger('callWhenClickOutside', [{
container: $popover.add($listElement),
callback: this.callbackWrapper(this.appendToggleIndicator_),
skipWhenVisibleModals: true
}]);
}
};
Expand Down

0 comments on commit f4969b3

Please sign in to comment.