Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ classic: adds relation initStore #144

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

pietrovismara
Copy link

@pietrovismara pietrovismara commented Jun 10, 2024

  • Drops references to Schema as the store now can be anything
  • Sets the initStore callback as $schema, so that Pair can use it
  • Adds a test in Relation.test.ts

Unrelated: improves the prefab check in getRelationTargets

Copy link
Owner

@NateTheGreatt NateTheGreatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work thanks for this! couple change requests since relations don't need schemas anymore

packages/classic/src/relation/Relation.ts Outdated Show resolved Hide resolved
packages/classic/src/relation/types.ts Outdated Show resolved Hide resolved
packages/classic/src/relation/types.ts Outdated Show resolved Hide resolved
packages/classic/src/relation/Relation.ts Outdated Show resolved Hide resolved
packages/classic/src/relation/Relation.ts Outdated Show resolved Hide resolved
@krispya krispya merged commit 0023e41 into NateTheGreatt:next Jun 24, 2024
@krispya
Copy link
Collaborator

krispya commented Jun 24, 2024

Looks good to me. I'm merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants