Ekir 232 add demarque classification #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natlibfi-kaisa
force-pushed
the
EKIR-232-Add-demarque-classification
branch
from
bcb15ff to
3085801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings back the needed chnages to add De Marque classifications to children's books. It weighs all de marque READ classifications to
1.0thus overriding all others which sends it to the top of classifications. De marque classification shows asDe Marquein the admin UI.Motivation and Context
Children's books has incorrect age and audience classifications which lead them to be classified as adult books. Also, some adult books were classified as children's books.
How Has This Been Tested?
Tested locally:
After adding library, collection and patron authentication details, run the odl2_import_monitor script in scripts. The books should now have appropriate classifications.
Checklist
New tests added for de marque.