Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit settings from default library #61

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

attemoi
Copy link
Contributor

@attemoi attemoi commented Apr 24, 2024

Other libraries now inherit any unset setting value from the default library.

Also, add new options to show/hide library settings in UI based on whether the library is the default or not. This allows:

  • Hiding the Kirkanta synchronization panel from default library.
  • Showing Filter&lane panel only for default library.
  • Hiding settings that don't need to be customized per Kimppa library.

The support e-mail and website are now optional to allow leaving those empty for Kimppa libraries.

Motivation and Context

https://jira.lingsoft.fi/browse/SIMPLYE-354 - Improve library settings handling

@attemoi attemoi force-pushed the feature/simplye-354/library-settings branch 5 times, most recently from 2f4eba3 to acdcdd1 Compare April 25, 2024 05:54
@attemoi attemoi marked this pull request as ready for review April 25, 2024 05:55
Other libraries now inherit any non-falsy or default value from the
default library.

Also, add new options to show/hide library settings in UI based on
whether the library is the default or not. This allows:

- Hiding the Kirkanta synchronization options from default library
- Showing Filter&lane panel only for default library
- Hiding settings that don't need to be customized per library for
  non-default libraries

Also makes the support e-mail and website optional, to allow leaving
those empty for Kimppa libraries.
@attemoi attemoi merged commit 8db109f into main Apr 25, 2024
24 checks passed
@attemoi attemoi deleted the feature/simplye-354/library-settings branch April 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants