Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show default library lanes for all libraries #55

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Show default library lanes for all libraries #55

merged 1 commit into from
Apr 22, 2024

Conversation

attemoi
Copy link
Contributor

@attemoi attemoi commented Apr 19, 2024 •
edited
Loading

Goal

Allow system admins to centrally manage a default set of lanes.

Solution

  • Lanes defined for the default library are shown for all other libraries.
  • Custom lanes defined for a library will show up on top of the lane catalog.
  • Resetting lanes for any other than default library just deletes all lanes without generating new ones.
    • The library will still show lanes from default library after reset.
  • Authorization rules changed to allow user from any library to fetch lanes from default library.

Motivation and Context

https://jira.lingsoft.fi/browse/SIMPLYE-320 - Default test user from Suomi.fi cannot see lanes defined by the system administrator

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@attemoi attemoi force-pushed the feature/simplye-320/lane-management branch 4 times, most recently from afc96a3 to 147da5c Compare April 22, 2024 07:39
@attemoi attemoi marked this pull request as ready for review April 22, 2024 07:43
sylvain-degeilh-lingsoft
sylvain-degeilh-lingsoft reviewed Apr 22, 2024
View reviewed changes
core/lane.py Outdated
@@ -1388,11 +1388,13 @@ def top_level_for_library(self, _db, library):
"""
# Load all of this Library's visible top-level Lane objects
# from the database.
# Finland, also include lanes fro mdefault library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"from default"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@attemoi attemoi force-pushed the feature/simplye-320/lane-management branch from 147da5c to b24c0f2 Compare April 22, 2024 08:03
@attemoi attemoi merged commit f47a20d into main Apr 22, 2024
24 checks passed
@attemoi attemoi deleted the feature/simplye-320/lane-management branch April 22, 2024 08:21
@attemoi attemoi mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvain-degeilh-lingsoft sylvain-degeilh-lingsoft sylvain-degeilh-lingsoft approved these changes

@ttuovinen ttuovinen Awaiting requested review from ttuovinen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attemoi @sylvain-degeilh-lingsoft