Fix borrowing for patrons in a consortium #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The licensepool query for patron `/borrow` endpoint does not include collections from the default library, resulting in the following error when patron tries to borrow books: `WARNING problem_detail.py "The item you're asking about (ISBN/9789515246646) isn't in this collection."` This commit changes the query to include the collections from the default library.
sylvain-degeilh-lingsoft
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The licensepool query for patron
/borrowendpoint does not include collections from the default library, resulting in the following error when patron tries to borrow books:WARNING problem_detail.py "The item you're asking about (ISBN/9789515246646) isn't in this collection."This commit changes the query to include the collections from the default library.
Motivation and Context
https://jira.lingsoft.fi/browse/SIMPLYE-263 - Implement custom lane management for local librarians
Checklist