Override library for authenticated patron requests #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attemoi
force-pushed
the
feature/simplye-263/custom-lane-management
branch
3 times, most recently
from
3055bd5 to
265e070
Compare
Each patron is assigned one library based on municipality. The clients are currently sending all requests towards the default library, which fails due to authorization. The alternative to this change would be to make the clients choose the correct library based on the authentication response.
| # Finland: For authenticated patrons, override the library defined in the request | ||
| # and use the library assigned to that patron. | ||
| # | ||
| # This is a bit sketchy as the authentication requires library to be set already. |
There was a problem hiding this comment.
Any risk to get duplicate records?
There was a problem hiding this comment.
I don't think duplicate records are a risk here. The risk is I might've missed some detail that would make this break in some specific cases. Pretty sure it's fine though. Selecting the library (automatically) on client side might be a bit safer as the requests would then use the default (upstream) logic.
sylvain-degeilh-lingsoft
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each patron is assigned one library based on municipality. The clients are currently sending all requests towards the default library. For patrons assigned to a library, this fails due to authorization.
The clients don't need to have access to multiple libraries so we can just override the library for the requests coming from authenticated patrons.
The alternative would be to make the clients choose the library based on the authentication response.