Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facet translations and ignore unnecessary .po files #39

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

attemoi
Copy link
Contributor

@attemoi attemoi commented Apr 9, 2024

This PR does three things:

  1. Adds Finnish and Swedish translations for language facets.
  2. Adds messages.po files to .gitignore. These are generated by bin/util/compile_translations.
  3. Enable translation for "All" option under "Collection Name" facet.

Motivation and Context

https://jira.lingsoft.fi/browse/SIMPLYE-280 - Language filter and its options are not translated in the apps
https://jira.lingsoft.fi/browse/SIMPLYE-281 - The string "All" is not translated in other filters than "Language" in the apps

attemoi added 2 commits April 9, 2024 12:48
These are automatically generated when translations are compiled
@attemoi attemoi merged commit e0a2c25 into main Apr 9, 2024
24 checks passed
@attemoi attemoi deleted the feature/simplye-280/translate branch April 9, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants