SIMPLYE-218 Passkey endpoints #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attemoi
reviewed
Feb 26, 2024
| authorization is None | ||
| or authorization.token is None | ||
| or len(authorization.token) == 0 | ||
| ): |
There was a problem hiding this comment.
This could be just if not authorization or not authorization.token:
attemoi
reviewed
Feb 26, 2024
| ) = self.get_tokens(request.authorization) | ||
| if isinstance(delegate_token, ProblemDetail): | ||
| return delegate_token | ||
| elif delegate_token == None: |
There was a problem hiding this comment.
could be elif not delegate_token, also handling empty string.
attemoi
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added endpoints to call "/passkey/register" endpoints at ekirjasto API on behalf of the enduser. Implementation was done so that it is easy to add more similar endpoints later.
Motivation and Context
The mobile client doesn't have ekirjasto token in usable form, "/passkey/register" endpoints requires those to authenticate requests.
See more at issue: SIMPLYE-218
How Has This Been Tested?
Checklist