Ekirjasto 18 show failed items during opds import #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natlibfi-kaisa
deleted the
ekirjasto-18-show-failed-items-during-opds-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds information to log a message about OPDS feed titles that fail during import.
Motivation and Context
When an OPDS feed is imported, it logs information about how many titles are imported and how many fail. However, it does not log what titles fail and what causes them to fail.
The log message in the admin UI in admin/web/troubleshooting/diagnostics/monitor under odl2 import monitor now shows which ISBNs fail and any recorded error message.
How Has This Been Tested?
Tested locally with new feed that contains one failing title.
Checklist