Fix mypy type checking errors #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix mypy type check errors.
attemoi
commented
Feb 6, 2024
| @@ -593,12 +594,14 @@ def create_bearer_token( | |||
| # Maybe we should use something custom instead. | |||
| iss=provider_name, | |||
| ) | |||
| return jwt.encode(payload, self.bearer_token_signing_secret, algorithm="HS256") | |||
| return jwt.encode( | |||
| payload, cast(str, self.bearer_token_signing_secret), algorithm="HS256" | |||
There was a problem hiding this comment.
This cast has been introduced in upstream as well.
attemoi
commented
Feb 6, 2024
| @@ -469,10 +476,6 @@ def remote_refresh_token(self, token: str) -> (str, int): | |||
| # Do nothing if authentication fails, e.g. token expired. | |||
| return INVALID_EKIRJASTO_TOKEN, None | |||
| elif response.status_code != 200: | |||
| msg = "Got unexpected response code %d. Content: %s" % ( | |||
There was a problem hiding this comment.
this msg is not referenced anywhere
attemoi
commented
Feb 6, 2024
| @@ -311,19 +311,12 @@ def test_secrets( | |||
| ): | |||
| provider = create_provider() | |||
|
|
|||
| # Secrets are not set, so this will fail. | |||
There was a problem hiding this comment.
The case of secrets not being set are also covered by the other test cases, so removed from here to fix mypy errors.
attemoi
force-pushed
the
feature/simplye-202/enable-mypy
branch
2 times, most recently
from
6ce474b to
f47fdd4
Compare
attemoi
requested review from
ttuovinen,
Kaappihullu,
mikko-work and
sylvain-degeilh-lingsoft
attemoi
force-pushed
the
feature/simplye-202/enable-mypy
branch
3 times, most recently
from
83cdc06 to
12005a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.lingsoft.fi/browse/SIMPLYE-202 - Enable Mypy type checks for ekirjasto-circulation in Github