Merge pull request #66 from NatLibFi/feature/simplye-322/dynamic-facets

Allow disabling dynamic facets

core/configuration/library.py

@@ -380,6 +380,22 @@ class LibrarySettings(BaseSettings):
             default_library_only=True,
         ),
     )
+    facets_enabled_dynamic: list[str] = FormField(
+        list(FacetConstants.FACET_DISPLAY_TITLES_DYNAMIC.keys()),
+        form=LibraryConfFormItem(
+            label="Allow patrons to filter by dynamic facets",
+            type=ConfigurationFormItemType.MENU,
+            options={
+                facet: FacetConstants.GROUP_DISPLAY_TITLES[facet]
+                for facet in FacetConstants.FACET_DISPLAY_TITLES_DYNAMIC.keys()
+            },
+            category="Lanes & Filters",
+            read_only=True,
+            format="narrow",
+            level=Level.SYS_ADMIN_ONLY,
+            default_library_only=True,
+        ),
+    )
     library_description: str | None = FormField(
         None,
         form=LibraryConfFormItem(

core/model/library.py

@@ -369,6 +369,10 @@ def entrypoints(self) -> Generator[type[EntryPoint] | None, None, None]:
 
     def enabled_facets(self, group_name: str) -> list[str]:
         """Look up the enabled facets for a given facet group."""
+
+        if self.is_facet_dynamic_and_disabled(group_name):
+            return []
+
         if group_name == FacetConstants.DISTRIBUTOR_FACETS_GROUP_NAME:
             enabled = []
             for collection in self.collections:
@@ -385,6 +389,12 @@ def enabled_facets(self, group_name: str) -> list[str]:
 
         return getattr(self.settings, f"facets_enabled_{group_name}")  # type: ignore[no-any-return]
 
+    def is_facet_dynamic_and_disabled(self, facet_group_name: str) -> bool:
+        return (
+            facet_group_name in FacetConstants.FACET_DISPLAY_TITLES_DYNAMIC
+            and not facet_group_name in self.settings.facets_enabled_dynamic
+        )
+
     @property
     def has_root_lanes(self) -> bool:
         """Does this library have any lanes that act as the root

tests/core/models/test_library.py

@@ -187,6 +187,7 @@ def test_explain(self, db: DatabaseTransactionFixture):
 facets_default_collection='full'
 facets_enabled_language='['all', 'fin', 'swe', 'eng', 'others']'
 facets_default_language='all'
+facets_enabled_dynamic='['distributor', 'collectionName']'
 help_web='http://library.com/support'
 default_notification_email_address='[email protected]'
 color_scheme='blue'