Initial E-kirjasto changes (Statistics section and branding) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor some utils and fix edge cases - remove obsolete function from FilterContext - prevent "undefined" flash in FinlandStats h1 render
(and remove console.log from FilterContext)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the initial E-kirjasto pull request to the NatLib repository that brings in the customisations made during fall 2023.
The PR depends on the initial ekirjasto-circulation changes which provide the endpoints for OpenSearch analytics queries: NatLibFi/ekirjasto-circulation#2
How Has This Been Tested?
These changes have been running and test-used on the beta environment.
There are new comprehensible unit tests for new components, hooks and utils in
src/finland/tests.The whole suite can be run with:
npm run test-finlandAnd a single test file with:
npm run test-jest-file src/finland/tests/[Filename].test.tsxChecklist: