Statistics improvements (Location and loan duration filtering) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,16 +76,28 @@ export const readableNames: Record<string, string> = { | |||
| fiction: "Fiktio", | |||
There was a problem hiding this comment.
"Kirjallisuus" is usually the term used for "Fiction" by the libraries.
In general, all terms in Finnish will have to be replaced with English as source and then passed to the localization.
I supposed this will be done at the same time as the localization is prepared.
sylvain-degeilh-lingsoft
approved these changes
Apr 22, 2024
Available facet values are always taken from all events associated with the selected library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Location as facet filter in statistics view
Loan duration facet filter in statistics view
Misc