This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Fixes, support for TravisCI @php7.2 & Codecov #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check your StyleCI dashboard and create a fix PR, because i can't. :D |
|
Hey @rennokki, thanks for your feedback :)! I am pretty sure this package can be improved and I am happy to have you onboard helping me! I am currently already working on an improvement using Laravels the stylecr thing will be fixed automatically when it is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. I love this package and i decided to fix a bit and add support for TravisCI @php7.2 & Codecov.
I usually use them, especially Codecov, and i have trouble when i want to start a new package: i just copy already done package's files and just re-write them a little bit so i can start a new one.
This is a good scaffolding. And i think it can be better.
Some of the devs are using StyleCI, and Codeclimate or Scrutinizer. Currently i am at the office and i cannot do really much, but in this evening i will add support for Scrutinizer & CircleCI.
Keep up the good work!