Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Add Trait Support #30

Closed
mmikhan opened this issue Aug 24, 2018 · 8 comments
Closed

Add Trait Support #30

mmikhan opened this issue Aug 24, 2018 · 8 comments

Comments

@mmikhan
Copy link

mmikhan commented Aug 24, 2018

Any plan to add a trait command support where the command will add traits inside the trait folder?

@Naoray
Copy link
Owner

Naoray commented Aug 24, 2018

@iamazik could u explain what u mean by that on an example?

@mmikhan
Copy link
Author

mmikhan commented Aug 24, 2018

I just simply want to run php artisan package:trait MyTrait command and that will create a MyTrait inside the src/Traits folder with the following stub:

<?php

namespace Vendor\Package\Traits;

trait MyTrait
{
    //
}

@Naoray
Copy link
Owner

Naoray commented Aug 24, 2018

@iamazik ah ok. Sure can do this.

You can create a PR for it or wait for @rennokki or me to implement it :)

@Naoray Naoray closed this as completed Aug 24, 2018
@Naoray
Copy link
Owner

Naoray commented Aug 25, 2018

@iamazik added package:trait command in v1.2.5

@mmikhan
Copy link
Author

mmikhan commented Aug 25, 2018

@Naoray Nice, don't forget to also add support for views :)

@Naoray
Copy link
Owner

Naoray commented Aug 25, 2018

@iamazik I don't think we need support for creating views. It's like config files... you only need to create a file and you are done.

@mmikhan
Copy link
Author

mmikhan commented Aug 25, 2018

Right, the confusion I always had is where to put it. So, I think it would be helpful for fresher and they won't have to this confusion again. Not sure if I was the only one with this confusion.

@Naoray
Copy link
Owner

Naoray commented Aug 25, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants