Add option to use fallback integration for user material functions #771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764.
Allows setting a
do_averaging
property on a user material function toTrue
(defaults toFalse
) to usefallback_chi1inv_row
.This was a little more complicated than the fix described in #764.
get_front_object
always returnsfalse
for a material function, so theif (material_type_equal(mat, mat_behind))
line is never reached.### TODORunning the script in issue #764 performs subpixel-averaging when settingdo_averaging
toTrue
, but fails in the harminv step withI traced this back tochi1inv_row
getting filled in withnan
s ingeom_epsilon::fallback_chi1inv_row
due to a divide by zero here. How should we handle this?