Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to waveguide mode converter topology optimization tutorial example #2878

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Aug 5, 2024

  1. Replace MMA algorithm with CCSA due to Epigraph slack hyperparameter? #2400.
  2. Remove unnecessary file context manager when writing Numpy archive file at the end of the optimization.
  3. Minor fixes and tweaks to docstrings and function names.

…Numpy archive file, and other fixes for waveguide mode converter topopt
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.78%. Comparing base (f29a8c7) to head (8af3a5c).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2878      +/-   ##
==========================================
- Coverage   73.81%   73.78%   -0.04%     
==========================================
  Files          18       18              
  Lines        5423     5428       +5     
==========================================
+ Hits         4003     4005       +2     
- Misses       1420     1423       +3     

@oskooi oskooi merged commit 2278c66 into NanoComp:master Aug 5, 2024
5 checks passed
@oskooi oskooi deleted the mode_converter_ccsa branch August 5, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants