Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checking for frequencies argument of OptimizationProblem constructor #2747

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Dec 26, 2023

Completes a TODO item left as a comment in python/adjoint/optimization_problem.py.

@oskooi oskooi requested a review from smartalecH December 26, 2023 23:14
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5494b9b) 74.06% compared to head (63f69fa) 74.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2747   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files          18       18           
  Lines        5395     5399    +4     
=======================================
+ Hits         3996     3999    +3     
- Misses       1399     1400    +1     
Files Coverage Δ
python/adjoint/optimization_problem.py 59.79% <83.33%> (+0.31%) ⬆️

@oskooi oskooi merged commit c92fd9b into NanoComp:master Dec 27, 2023
5 checks passed
@oskooi oskooi deleted the optprob_freq_type_check branch December 27, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants